[19.0][OU-IMP] crm: Add separator to phone and mobile concatenation#5763
Merged
Conversation
OCA-git-bot
added
mod:openupgrade_scripts
pedrobaeza
reviewed
Jun 29, 2026
pedrobaeza
left a comment
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
As you are here, please make a copy of the column first for preserving original information.
Contributor
Author
|
Do you mean creating an extra column like |
Member
|
Use |
MiquelRForgeFlow
requested changes
Jul 9, 2026
MiquelRForgeFlow
left a comment
MiquelRForgeFlow
left a comment
Contributor
There was a problem hiding this comment.
Same comments as #5762. What about phone_validation module?
Member
|
|
Contributor
|
I meant that what we finally do in #5762, we have to it here too. |
Member
|
Yes, but the problem you state with |
christian-ramos-tecnativa
force-pushed
the
19.0-ou-crm-mobile
branch
from
c7ee217 to
b0be136
Compare
Contributor
Author
|
Added |
pedrobaeza
reviewed
Jul 10, 2026
christian-ramos-tecnativa
force-pushed
the
19.0-ou-crm-mobile
branch
from
b0be136 to
635b88f
Compare
eduezerouali-tecnativa
approved these changes
Jul 10, 2026
pedrobaeza
approved these changes
Jul 10, 2026
MiquelRForgeFlow
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depending on how the user wrote down the phone and mobile fields, after the migration the phone can get ambiguous. Added a separator to avoid it.
@Tecnativa
@pedrobaeza @eduezerouali-tecnativa